fix(desktop): stabilize Runtime Host Session lifecycle races - #2548
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
Stabilize two Desktop lifecycle paths that could race with Runtime Host Session revision changes:
The side-chat E2E now dismisses a Turn that deliberately remains active, so it verifies the production stop-before-retire contract. The Session client regression crosses four consecutive revision conflicts before committing, which reproduces the window that exceeded the previous three-attempt bound.
Fixes #2543
Fixes #2545
Verification
npx biome checkon all changed filesnpm run typecheck --workspace @maka/desktop --if-presentnpm run build:testmainChecklist
Does this PR entail a change in behavior?
中文
摘要
修复两条会与 Runtime Host Session revision 变化发生竞态的 Desktop 生命周期路径：
侧边对话 E2E 现在会关闭一个刻意保持运行的 Turn，因此能验证生产路径的“先停止、后退休”契约。Session client 回归测试则会连续经历四次 revision conflict 后再提交，覆盖原三次尝试上限不足的窗口。
修复 #2543
修复 #2545
验证
npx biome checknpm run typecheck --workspace @maka/desktop --if-presentnpm run build:testmain后再次运行 2/2 通过检查清单
此 PR 是否包含行为变化？